Commit 4693c249 authored by Linus Walleij's avatar Linus Walleij Committed by Greg Ungerer
Browse files

m68k: coldfire/gpio: Be sure to clamp return value

As we want gpio_chip .get() calls to be able to return negative
error codes and propagate to drivers, we need to go over all
drivers and make sure their return values are clamped to [0,1].
We do this by using the ret = !!(val) design pattern.

Cc: Geert Uytterhoeven <>
Cc: Greg Ungerer <>
Signed-off-by: default avatarLinus Walleij <>
Signed-off-by: default avatarGreg Ungerer <>
parent 16830985
......@@ -121,7 +121,7 @@ static int mcfgpio_direction_input(struct gpio_chip *chip, unsigned offset)
static int mcfgpio_get_value(struct gpio_chip *chip, unsigned offset)
return __mcfgpio_get_value(offset);
return !!__mcfgpio_get_value(offset);
static int mcfgpio_direction_output(struct gpio_chip *chip, unsigned offset,
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment