Commit 4104863f authored by Julia Lawall's avatar Julia Lawall Committed by John W. Linville
Browse files

b43legacy: Release mutex in error handling code

The mutex is released on a successful return, so it would seem that it
should be released on an error return as well.

The semantic patch finds this problem is as follows:
(http://www.emn.fr/x-info/coccinelle/

)

// <smpl>
@@
expression l;
@@

mutex_lock(l);
... when != mutex_unlock(l)
    when any
    when strict
(
if (...) { ... when != mutex_unlock(l)
+   mutex_unlock(l);
    return ...;
}
|
mutex_unlock(l);
)
// </smpl>
Signed-off-by: default avatarJulia Lawall <julia@diku.dk>
Signed-off-by: default avatarMichael Buesch <mb@bu3sch.de>
Cc: stable <stable@kernel.org>
Signed-off-by: default avatarJohn W. Linville <linville@tuxdriver.com>
parent 80c42aff
...@@ -3845,10 +3845,10 @@ static int b43legacy_resume(struct ssb_device *dev) ...@@ -3845,10 +3845,10 @@ static int b43legacy_resume(struct ssb_device *dev)
goto out; goto out;
} }
} }
mutex_unlock(&wl->mutex);
b43legacydbg(wl, "Device resumed.\n"); b43legacydbg(wl, "Device resumed.\n");
out: out:
mutex_unlock(&wl->mutex);
return err; return err;
} }
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment