Commit 40995fa3 authored by Sascha Hauer's avatar Sascha Hauer Committed by Greg Kroah-Hartman

serial: imx: Fix DCD reading

commit 4b75f80003617fe35771a9e27022e8fbd6a41875 upstream.

The USR2_DCDIN bit is tested for in register usr1. As the name
suggests the usr2 register should be used instead. This fixes
reading the Carrier detect status.
Signed-off-by: default avatarSascha Hauer <>
Fixes: 90ebc483 ("serial: imx: repair and complete handshaking")
Acked-by: default avatarUwe Kleine-König <>
Reviewed-by: default avatarFabio Estevam <>
Signed-off-by: default avatarGreg Kroah-Hartman <>
parent 1888926e
......@@ -740,12 +740,13 @@ static unsigned int imx_get_hwmctrl(struct imx_port *sport)
unsigned int tmp = TIOCM_DSR;
unsigned usr1 = readl(sport->port.membase + USR1);
unsigned usr2 = readl(sport->port.membase + USR2);
if (usr1 & USR1_RTSS)
tmp |= TIOCM_CTS;
/* in DCE mode DCDIN is always 0 */
if (!(usr1 & USR2_DCDIN))
if (!(usr2 & USR2_DCDIN))
tmp |= TIOCM_CAR;
if (sport->dte_mode)
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment