Commit 3e84f48e authored by Al Viro's avatar Al Viro Committed by Linus Torvalds
Browse files

vfs/splice: Fix missed checks in new __kernel_write() helper

Commit 06ae43f3

 ("Don't bother with redoing rw_verify_area() from
default_file_splice_from()") lost the checks to test existence of the
write/aio_write methods.  My apologies ;-/

Eventually, we want that in fs/splice.c side of things (no point
repeating it for every buffer, after all), but for now this is the
obvious minimal fix.
Reported-by: default avatarDave Jones <>
Signed-off-by: default avatarAl Viro <>
Signed-off-by: default avatarLinus Torvalds <>
parent de55eb1d
......@@ -424,6 +424,9 @@ ssize_t __kernel_write(struct file *file, const char *buf, size_t count, loff_t
const char __user *p;
ssize_t ret;
if (!file->f_op || (!file->f_op->write && !file->f_op->aio_write))
return -EINVAL;
old_fs = get_fs();
p = (__force const char __user *)buf;
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment