Commit 3daeb42c authored by Dave Chinner's avatar Dave Chinner Committed by Alex Elder
Browse files

xfs: fix missing error check in xfs_rtfree_range

When xfs_rtfind_forw() returns an error, the block is returned
uninitialised.  xfs_rtfree_range() is not checking the error return,
so could be using an uninitialised block number for modifying bitmap
summary info.

The problem was found by gcc when compiling the *userspace* libxfs
code - it is an copy of the kernel code with the exact same bug.
gcc gives an uninitialised variable warning on the userspace code
but not on the kernel code. You gotta love the consistency (Mmmm,
slightly chewy today!).
Signed-off-by: default avatarDave Chinner <>
Signed-off-by: default avatarAlex Elder <>
parent 4b6a4688
......@@ -1517,6 +1517,8 @@ xfs_rtfree_range(
error = xfs_rtfind_forw(mp, tp, end, mp->m_sb.sb_rextents - 1,
if (error)
return error;
* If there are blocks not being freed at the front of the
* old extent, add summary data for them to be allocated.
Supports Markdown
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment