Commit 3d9646d0 authored by Johannes Berg's avatar Johannes Berg
Browse files

mac80211: fix channel selection bug

When trying to connect to an AP that advertises HT but not
VHT, the mac80211 code erroneously uses the configuration
from the AP as is instead of checking it against regulatory
and local capabilities. This can lead to using an invalid
or even inexistent channel (like 11/HT40+).

Additionally, the return flags from downgrading must be
ORed together, to collect them from all of the downgrades.
Also clarify the message.

Signed-off-by: default avatarJohannes Berg <>
parent d601cd8d
......@@ -3400,6 +3400,7 @@ ieee80211_determine_chantype(struct ieee80211_sub_if_data *sdata,
ret = 0;
while (!cfg80211_chandef_usable(sdata->local->hw.wiphy, chandef,
if (WARN_ON(chandef->width == NL80211_CHAN_WIDTH_20_NOHT)) {
......@@ -3408,14 +3409,13 @@ ieee80211_determine_chantype(struct ieee80211_sub_if_data *sdata,
goto out;
ret = chandef_downgrade(chandef);
ret |= chandef_downgrade(chandef);
if (chandef->width != vht_chandef.width)
"local regulatory prevented using AP HT/VHT configuration, downgraded\n");
"capabilities/regulatory prevented using AP HT/VHT configuration, downgraded\n");
return ret;
Supports Markdown
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment