Commit 3d67f2d7 authored by Nick Piggin's avatar Nick Piggin Committed by Linus Torvalds
Browse files

fs: buffer don't PageUptodate without page locked

__block_write_full_page is calling SetPageUptodate without the page locked.
This is unusual, but not incorrect, as PG_writeback is still set.

However the next patch will require that SetPageUptodate always be called with
the page locked.  Simply don't bother setting the page uptodate in this case
(it is unusual that the write path does such a thing anyway).  Instead just
leave it to the read side to bring the page uptodate when it notices that all
buffers are uptodate.
Signed-off-by: default avatarNick Piggin <>
Cc: Hugh Dickins <>
Signed-off-by: default avatarAndrew Morton <>
Signed-off-by: default avatarLinus Torvalds <>
parent 6fe6900e
......@@ -1700,17 +1700,8 @@ done:
* clean. Someone wrote them back by hand with
* ll_rw_block/submit_bh. A rare case.
int uptodate = 1;
do {
if (!buffer_uptodate(bh)) {
uptodate = 0;
bh = bh->b_this_page;
} while (bh != head);
if (uptodate)
* The page and buffer_heads can be released at any time from
* here on.
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment