Commit 3d2c5b41 authored by Ben Dooks's avatar Ben Dooks Committed by Linus Torvalds
Browse files

spi: fix use of set_cs in spi_s3c24xx driver

It turns out that the last patch to change set_cs to be kept in the
controller's structure instead of the platform data was an incomplete
change, and did not change the references to platfrom data in the setup
xfer code.  (This can prevent an oops.)

Reported-by: <>
Signed-off-by: default avatarBen Dooks <>
Signed-off-by: default avatarDavid Brownell <>
Signed-off-by: default avatarAndrew Morton <>
Signed-off-by: default avatarLinus Torvalds <>
parent 88ed39b0
......@@ -77,7 +77,7 @@ static void s3c24xx_spi_chipsel(struct spi_device *spi, int value)
switch (value) {
hw->pdata->set_cs(hw->pdata, spi->chip_select, cspol^1);
hw->set_cs(hw->pdata, spi->chip_select, cspol^1);
......@@ -98,7 +98,7 @@ static void s3c24xx_spi_chipsel(struct spi_device *spi, int value)
/* write new configration */
writeb(spcon, hw->regs + S3C2410_SPCON);
hw->pdata->set_cs(hw->pdata, spi->chip_select, cspol);
hw->set_cs(hw->pdata, spi->chip_select, cspol);
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment