Commit 3a49f3d2 authored by Andy Shevchenko's avatar Andy Shevchenko Committed by Linus Torvalds

fs/proc/array.c: set overflow flag in case of error

For now in task_name() we ignore the return code of string_escape_str()
call.  This is not good if buffer suddenly becomes not big enough.  Do the
proper error handling there.
Signed-off-by: default avatarAndy Shevchenko <>
Cc: Alexander Viro <>
Signed-off-by: default avatarAndrew Morton <>
Signed-off-by: default avatarLinus Torvalds <>
parent 1965c8b7
......@@ -91,18 +91,18 @@
static inline void task_name(struct seq_file *m, struct task_struct *p)
char *buf;
size_t size;
char tcomm[sizeof(p->comm)];
int ret;
get_task_comm(tcomm, p);
seq_puts(m, "Name:\t");
buf = m->buf + m->count;
/* Ignore error for now */
buf += string_escape_str(tcomm, buf, m->size - m->count,
size = seq_get_buf(m, &buf);
ret = string_escape_str(tcomm, buf, size, ESCAPE_SPACE | ESCAPE_SPECIAL, "\n\\");
seq_commit(m, ret < size ? ret : -1);
m->count = buf - m->buf;
seq_putc(m, '\n');
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment