Commit 38691593 authored by Darrick J. Wong's avatar Darrick J. Wong Committed by James Bottomley
Browse files

[SCSI] sas_ata: Don't copy aic94xx's sactive to ata_port



Since the aic94xx sequencer assigns its own NCQ tags to ATA commands, it
no longer makes any sense to copy the sactive field in the STP response
to ata_port->sactive, as that will confuse libata.  Also, libata seems
to be capable of managing sactive on its own.

The attached patch gets rid of one of the causes of the BUG messages in
ata_qc_new, and seems to work without problems on an IBM x206m.
Signed-off-by: default avatarDarrick J. Wong <djwong@us.ibm.com>
Signed-off-by: default avatarJames Bottomley <James.Bottomley@SteelEye.com>
parent 1c50dc83
...@@ -106,7 +106,6 @@ static void sas_ata_task_done(struct sas_task *task) ...@@ -106,7 +106,6 @@ static void sas_ata_task_done(struct sas_task *task)
dev->sata_dev.sstatus = resp->sstatus; dev->sata_dev.sstatus = resp->sstatus;
dev->sata_dev.serror = resp->serror; dev->sata_dev.serror = resp->serror;
dev->sata_dev.scontrol = resp->scontrol; dev->sata_dev.scontrol = resp->scontrol;
dev->sata_dev.ap->sactive = resp->sactive;
} else if (stat->stat != SAM_STAT_GOOD) { } else if (stat->stat != SAM_STAT_GOOD) {
ac = sas_to_ata_err(stat); ac = sas_to_ata_err(stat);
if (ac) { if (ac) {
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment