Commit 332dd96f authored by Eric Dumazet's avatar Eric Dumazet Committed by David S. Miller
Browse files

net/dst: dst_dev_event() called after other notifiers

Followup of commit ef885afb

 (net: use rcu_barrier() in
rollback_registered_many)

dst_dev_event() scans a garbage dst list that might be feeded by various
network notifiers at device dismantle time.

Its important to call dst_dev_event() after other notifiers, or we might
enter the infamous msleep(250) in netdev_wait_allrefs(), and wait one
second before calling again call_netdevice_notifiers(NETDEV_UNREGISTER,
dev) to properly remove last device references.

Use priority -10 to let dst_dev_notifier be called after other network
notifiers (they have the default 0 priority)
Reported-by: default avatarBen Greear <greearb@candelatech.com>
Reported-by: default avatarNicolas Dichtel <nicolas.dichtel@6wind.com>
Reported-by: default avatarOctavian Purdila <opurdila@ixiacom.com>
Reported-by: default avatarBenjamin LaHaise <bcrl@kvack.org>
Tested-by: default avatarBen Greear <greearb@candelatech.com>
Signed-off-by: default avatarEric Dumazet <eric.dumazet@gmail.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 88f8a5e3
...@@ -370,6 +370,7 @@ static int dst_dev_event(struct notifier_block *this, unsigned long event, ...@@ -370,6 +370,7 @@ static int dst_dev_event(struct notifier_block *this, unsigned long event,
static struct notifier_block dst_dev_notifier = { static struct notifier_block dst_dev_notifier = {
.notifier_call = dst_dev_event, .notifier_call = dst_dev_event,
.priority = -10, /* must be called after other network notifiers */
}; };
void __init dst_init(void) void __init dst_init(void)
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment