Commit 1f8f4559 authored by Micah Gruber's avatar Micah Gruber Committed by David S. Miller
Browse files

Fix a potential NULL pointer dereference in uli526x_interrupt() in drivers/net/tulip/uli526x.c

This patch fixes an apparent potential null dereference bug where we
dereference dev before a null check.  This patch simply remvoes the
can't-happen test for a null pointer.
Signed-off-by: default avatarMicah Gruber <>
Cc: Grant Grundler <>
Acked-by: default avatarJeff Garzik <>
Acked-by: default avatarKyle McMartin <>
Signed-off-by: default avatarAndrew Morton <>
Signed-off-by: default avatarJeff Garzik <>
parent 13f7b8c0
......@@ -664,11 +664,6 @@ static irqreturn_t uli526x_interrupt(int irq, void *dev_id)
unsigned long ioaddr = dev->base_addr;
unsigned long flags;
if (!dev) {
ULI526X_DBUG(1, "uli526x_interrupt() without DEVICE arg", 0);
return IRQ_NONE;
spin_lock_irqsave(&db->lock, flags);
outl(0, ioaddr + DCR7);
Supports Markdown
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment