Commit 1dd594b2 authored by Neil Brown's avatar Neil Brown Committed by Trond Myklebust
Browse files

NFS: Fix buglet in fs/nfs/write.c



I've been reading through fs/nfs/write.c trying to track down a bug
that seems to be related to pages loosing a refcount and getting
freed too early (you interested in detail??) and I spotted a little
bug which the following patch should fix.

Signed-off-by: default avatarNeil Brown <neilb@suse.de>
Signed-off-by: default avatarTrond Myklebust <Trond.Myklebust@netapp.com>
parent cd52ed35
......@@ -653,8 +653,11 @@ static struct nfs_page * nfs_update_request(struct nfs_open_context* ctx,
spin_unlock(&nfsi->req_lock);
error = nfs_wait_on_request(req);
nfs_release_request(req);
if (error < 0)
if (error < 0) {
if (new)
nfs_release_request(new);
return ERR_PTR(error);
}
continue;
}
spin_unlock(&nfsi->req_lock);
......
Supports Markdown
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment