Commit 17b85d29 authored by Nikolay Aleksandrov's avatar Nikolay Aleksandrov Committed by David S. Miller

net/core: revert "net: fix __netdev_update_features return.." and add comment

This reverts commit 00ee5927 ("net: fix __netdev_update_features return
on ndo_set_features failure")
and adds a comment explaining why it's okay to return a value other than
0 upon error. Some drivers might actually change flags and return an
error so it's better to fire a spurious notification rather than miss

CC: Michał Mirosław <>
Signed-off-by: default avatarNikolay Aleksandrov <>
Signed-off-by: default avatarDavid S. Miller <>
parent a3a116e0
......@@ -6436,7 +6436,10 @@ int __netdev_update_features(struct net_device *dev)
"set_features() failed (%d); wanted %pNF, left %pNF\n",
err, &features, &dev->features);
return 0;
/* return non-0 since some features might have changed and
* it's better to fire a spurious notification than miss it
return -1;
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment