Commit 176306f5 authored by Neil Brown's avatar Neil Brown Committed by Al Viro

VFS: fix recent breakage of FS_REVAL_DOT

Commit 1f36f774 broke FS_REVAL_DOT semantics.

In particular, before this patch, the command
   ls -l
in an NFS mounted directory would always check if the directory on the server
had changed and if so would flush and refill the pagecache for the dir.
After this patch, the same "ls -l" will repeatedly return stale date until
the cached attributes for the directory time out.

The following patch fixes this by ensuring the d_revalidate is called by
do_last when "." is being looked-up.
link_path_walk has already called d_revalidate, but in that case LOOKUP_OPEN
is not set so nfs_lookup_verify_inode chooses not to do any validation.

The following patch restores the original behaviour.

Signed-off-by: default avatarNeilBrown <>
Signed-off-by: default avatarAl Viro <>
parent 1eb2cbb6
......@@ -1621,6 +1621,7 @@ static struct file *do_last(struct nameidata *nd, struct path *path,
dir = nd->path.dentry;
case LAST_DOT:
if (nd->path.mnt->mnt_sb->s_type->fs_flags & FS_REVAL_DOT) {
if (!dir->d_op->d_revalidate(dir, nd)) {
error = -ESTALE;
......@@ -1628,7 +1629,6 @@ static struct file *do_last(struct nameidata *nd, struct path *path,
/* fallthrough */
case LAST_DOT:
if (open_flag & O_CREAT)
goto exit;
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment