Commit 1492616a authored by Axel Lin's avatar Axel Lin Committed by Matthew Garrett
Browse files

wmi: fix a memory leak in wmi_notify_debug

When acpi_evaluate_object() is passed ACPI_ALLOCATE_BUFFER,
the caller must kfree the returned buffer if AE_OK is returned.

The callers of wmi_get_event_data() pass ACPI_ALLOCATE_BUFFER,
and thus must check its return value before accessing
or kfree() on the buffer.

This patch adds return value checking for wmi_get_event_data()
and adds a missing kfree(obj) in the end of wmi_notify_debug
Signed-off-by: default avatarAxel Lin <>
Acked-by: default avatarThomas Renninger <>
Signed-off-by: default avatarMatthew Garrett <>
parent d5164dbf
......@@ -518,8 +518,13 @@ static void wmi_notify_debug(u32 value, void *context)
struct acpi_buffer response = { ACPI_ALLOCATE_BUFFER, NULL };
union acpi_object *obj;
acpi_status status;
wmi_get_event_data(value, &response);
status = wmi_get_event_data(value, &response);
if (status != AE_OK) {
printk(KERN_INFO "wmi: bad event status 0x%x\n", status);
obj = (union acpi_object *)response.pointer;
......@@ -543,6 +548,7 @@ static void wmi_notify_debug(u32 value, void *context)
printk("object type 0x%X\n", obj->type);
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment