Commit 088df2cc authored by Hans de Goede's avatar Hans de Goede Committed by Dmitry Torokhov
Browse files

Input: alps - do not reduce trackpoint speed by half

On some v7 devices (e.g. Lenovo-E550) the deltas reported are typically
only in the 0-1 range dividing this by 2 results in a range of 0-0.

And even for v7 devices where this does not lead to making the trackstick
entirely unusable, it makes it twice as slow as before we added v7 support
and were using the ps/2 mouse emulation of the dual point setup.

If some kind of generic slowdown is actually necessary for some devices,
then that belongs in userspace, not in the kernel.

Reported-and-tested-by: default avatarRico Moorman <>
Signed-off-by: default avatarHans de Goede <>
Reviewed-by: default avatarBenjamin Tissoires <>
Signed-off-by: default avatarDmitry Torokhov <>
parent 692dd191
...@@ -1063,9 +1063,8 @@ static void alps_process_trackstick_packet_v7(struct psmouse *psmouse) ...@@ -1063,9 +1063,8 @@ static void alps_process_trackstick_packet_v7(struct psmouse *psmouse)
right = (packet[1] & 0x02) >> 1; right = (packet[1] & 0x02) >> 1;
middle = (packet[1] & 0x04) >> 2; middle = (packet[1] & 0x04) >> 2;
/* Divide 2 since trackpoint's speed is too fast */ input_report_rel(dev2, REL_X, (char)x);
input_report_rel(dev2, REL_X, (char)x / 2); input_report_rel(dev2, REL_Y, -((char)y));
input_report_rel(dev2, REL_Y, -((char)y / 2));
input_report_key(dev2, BTN_LEFT, left); input_report_key(dev2, BTN_LEFT, left);
input_report_key(dev2, BTN_RIGHT, right); input_report_key(dev2, BTN_RIGHT, right);
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment