Commit 07d5035a authored by Dave Chinner's avatar Dave Chinner Committed by Dave Chinner
Browse files

xfs: wrong error sign conversion during failed DIO writes

We negate the error value being returned from a generic function
incorrectly. The code path that it is running in returned negative
errors, so there is no need to negate it to get the correct error
signs here.

This was uncovered by generic/019.
Signed-off-by: default avatarDave Chinner <>
Reviewed-by: default avatarChristoph Hellwig <>
Signed-off-by: default avatarDave Chinner <>
parent 9c23eccc
...@@ -679,7 +679,7 @@ xfs_file_dio_aio_write( ...@@ -679,7 +679,7 @@ xfs_file_dio_aio_write(
goto out; goto out;
if (mapping->nrpages) { if (mapping->nrpages) {
ret = -filemap_write_and_wait_range(VFS_I(ip)->i_mapping, ret = filemap_write_and_wait_range(VFS_I(ip)->i_mapping,
pos, -1); pos, -1);
if (ret) if (ret)
goto out; goto out;
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment