Commit 06e63c57 authored by Ben Hutchings's avatar Ben Hutchings
Browse files

sfc: Use a more sensible cast in efx_rx_buf_offset()

This function returns the page offset of the buffer, which can be
calculated based on either its DMA address or its virtual address.  It
used to use the virtual address and we would cast that to unsigned
long, as anything smaller would result in a compiler warning.  Now
that it's using the DMA address we should use unsigned int, matching
the return type.  It is also unnecessary to use __force.
Signed-off-by: default avatarBen Hutchings <>
parent 8b1c36b3
......@@ -98,7 +98,7 @@ static inline unsigned int efx_rx_buf_offset(struct efx_nic *efx,
/* Offset is always within one page, so we don't need to consider
* the page order.
return ((__force unsigned long) buf->dma_addr & (PAGE_SIZE - 1)) +
return ((unsigned int) buf->dma_addr & (PAGE_SIZE - 1)) +
static inline unsigned int efx_rx_buf_size(struct efx_nic *efx)
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment