Commit 018027be authored by Dave Chinner's avatar Dave Chinner Committed by Alex Elder
Browse files

xfs: Avoid inodes in reclaim when flushing from inode cache

The reclaim code will handle flushing of dirty inodes before reclaim
occurs, so avoid them when determining whether an inode is a
candidate for flushing to disk when walking the radix trees.  This
is based on a test patch from Christoph Hellwig.
Signed-off-by: default avatarDave Chinner <>
Reviewed-by: default avatarChristoph Hellwig <>
Signed-off-by: default avatarAlex Elder <>
parent c8e20be0
......@@ -180,26 +180,31 @@ xfs_sync_inode_valid(
struct xfs_perag *pag)
struct inode *inode = VFS_I(ip);
int error = EFSCORRUPTED;
/* nothing to sync during shutdown */
if (XFS_FORCED_SHUTDOWN(ip->i_mount)) {
if (XFS_FORCED_SHUTDOWN(ip->i_mount))
goto out_unlock;
/* If we can't get a reference on the inode, it must be in reclaim. */
if (!igrab(inode)) {
return ENOENT;
/* avoid new or reclaimable inodes. Leave for reclaim code to flush */
error = ENOENT;
if (xfs_iflags_test(ip, XFS_INEW | XFS_IRECLAIMABLE | XFS_IRECLAIM))
goto out_unlock;
if (is_bad_inode(inode) || xfs_iflags_test(ip, XFS_INEW)) {
/* If we can't grab the inode, it must on it's way to reclaim. */
if (!igrab(inode))
goto out_unlock;
if (is_bad_inode(inode)) {
return ENOENT;
goto out_unlock;
return 0;
/* inode is valid */
error = 0;
return error;
Supports Markdown
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment