Commit 00fdc6bb authored by Nicholas Bellinger's avatar Nicholas Bellinger

iscsi-target: Fix reservation conflict -EBUSY response handling bug

This patch addresses a iscsi-target specific bug related to reservation conflict
handling in iscsit_handle_scsi_cmd() that has been causing reservation conflicts
to complete and not fail as expected due to incorrect errno checking.  The problem
occured with the change to return -EBUSY from transport_generic_cmd_sequencer() ->
transport_generic_allocate_tasks() failures, that broke iscsit_handle_scsi_cmd()
checking for -EINVAL in order to invoke a non GOOD status response.

This was manifesting itself as data corruption with legacy SPC-2 reservations,
but also effects iscsi-target LUNs with SPC-3 persistent reservations.

This bug was originally introduced in lio-core commit:

commit 03e98c9e
Author: Nicholas Bellinger <>
Date:   Fri Nov 4 02:36:16 2011 -0700

    target: Address legacy PYX_TRANSPORT_* return code breakage
Reported-by: default avatarMartin Svec <>
Cc: Martin Svec <>
Cc: Christoph Hellwig <>
Signed-off-by: default avatarNicholas Bellinger <>
parent 087a03b3
......@@ -1028,7 +1028,7 @@ done:
return iscsit_add_reject_from_cmd(
1, 1, buf, cmd);
} else if (transport_ret == -EINVAL) {
} else if (transport_ret < 0) {
* Unsupported SAM Opcode. CHECK_CONDITION will be sent
* in iscsit_execute_cmd() during the CmdSN OOO Execution
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment