Skip to content
  • Miklos Szeredi's avatar
    [GFS2] don't call permission() · f58ba889
    Miklos Szeredi authored
    
    
    GFS2 calls permission() to verify permissions after locks on the files
    have been taken.
    
    For this it's sufficient to call gfs2_permission() instead.  This
    results in the following changes:
    
      - IS_RDONLY() check is not performed
      - IS_IMMUTABLE() check is not performed
      - devcgroup_inode_permission() is not called
      - security_inode_permission() is not called
    
    IS_RDONLY() should be unnecessary anyway, as the per-mount read-only
    flag should provide protection against read-only remounts during
    operations.  do_gfs2_set_flags() has been fixed to perform
    mnt_want_write()/mnt_drop_write() to protect against remounting
    read-only.
    
    IS_IMMUTABLE has been added to gfs2_permission()
    
    Repeating the security checks seems to be pointless, as they don't
    normally change, and if they do, it's independent of the filesystem
    state.
    
    Signed-off-by: default avatarMiklos Szeredi <mszeredi@suse.cz>
    Signed-off-by: default avatarSteven Whitehouse <swhiteho@redhat.com>
    f58ba889