• David S. Miller's avatar
    [IPV6]: Fix routing round-robin locking. · f11e6659
    David S. Miller authored
    As per RFC2461, section 6.3.6, item #2, when no routers on the
    matching list are known to be reachable or probably reachable we
    do round robin on those available routes so that we make sure
    to probe as many of them as possible to detect when one becomes
    reachable faster.
    Each routing table has a rwlock protecting the tree and the linked
    list of routes at each leaf.  The round robin code executes during
    lookup and thus with the rwlock taken as a reader.  A small local
    spinlock tries to provide protection but this does not work at all
    for two reasons:
    1) The round-robin list manipulation, as coded, goes like this (with
       read lock held):
    	walk routes finding head and tail
    	rotate list using head and tail
       While one thread is rotating the list, another thread can
       end up with stale values of head and tail and then proceed
       to corrupt the list when it gets the lock.  This ends up causing
       the OOPS in fib6_add() later onthat many people have been hitting.
    2) All the other code paths that run with the rwlock held as
       a reader do not expect the list to change on them, they
       expect it to remain completely fixed while they hold the
       lock in that way.
    So, simply stated, it is impossible to implement this correctly using
    a manipulation of the list without violating the rwlock locking
    Reimplement using a per-fib6_node round-robin pointer.  This way we
    don't need to manipulate the list at all, and since the round-robin
    pointer can only ever point to real existing entries we don't need
    to perform any locking on the changing of the round-robin pointer
    itself.  We only need to reset the round-robin pointer to NULL when
    the entry it is pointing to is removed.
    The idea is from Thomas Graf and it is very similar to how this
    was implemented before the advanced router selection code when in.
    Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
ip6_fib.h 4.8 KB