Skip to content
  • David Sterba's avatar
    btrfs: fix uninitialized variable warning · aa0467d8
    David Sterba authored
    With Linus' tree, today's linux-next build (powercp ppc64_defconfig)
    produced this warning:
    
    fs/btrfs/delayed-inode.c: In function 'btrfs_delayed_update_inode':
    fs/btrfs/delayed-inode.c:1598:6: warning: 'ret' may be used
    uninitialized in this function
    
    Introduced by commit 16cdcec7
    
     ("btrfs: implement delayed inode items
    operation").
    
    This fixes a bug in btrfs_update_inode(): if the returned value from
    btrfs_delayed_update_inode is a nonzero garbage, inode stat data are not
    updated and several call paths may hit a BUG_ON or fail with strange
    code.
    
    Reported-by: default avatarStephen Rothwell <sfr@canb.auug.org.au>
    Signed-off-by: default avatarDavid Sterba <dsterba@suse.cz>
    aa0467d8