Skip to content
  • NeilBrown's avatar
    md/raid10: fix problem with on-stack allocation of r10bio structure. · e0ee7785
    NeilBrown authored
    
    
    A 'struct r10bio' has an array of per-copy information at the end.
    This array is declared with size [0] and r10bio_pool_alloc allocates
    enough extra space to store the per-copy information depending on the
    number of copies needed.
    
    So declaring a 'struct r10bio on the stack isn't going to work.  It
    won't allocate enough space, and memory corruption will ensue.
    
    So in the two places where this is done, declare a sufficiently large
    structure and use that instead.
    
    The two call-sites of this bug were introduced in 3.4 and 3.5
    so this is suitable for both those kernels.  The patch will have to
    be modified for 3.4 as it only has one bug.
    
    Cc: stable@vger.kernel.org
    Reported-by: default avatarIvan Vasilyev <ivan.vasilyev@gmail.com>
    Tested-by: default avatarIvan Vasilyev <ivan.vasilyev@gmail.com>
    Signed-off-by: default avatarNeilBrown <neilb@suse.de>
    e0ee7785