Skip to content
  • Alan Cox's avatar
    [PATCH] libata: fix combined mode · dc3c3377
    Alan Cox authored
    
    
    This is a slight variant on the patch I posted December 16th to fix
    libata combined mode handling. The only real change is that we now
    correctly also reserve BAR1,2,4. That is basically a neatness issue.
    
    Jeff was unhappy about two things
    
    1. That it didn't work in the case of one channel native one channel
    legacy.
    
    This is a silly complaint because the SFF layer in libata doesn't handle
    this case yet anyway.
    
    2. The case where combined mode is in use and IDE=n.
    
    In this case the libata quirk code reserves the resources in question
    correctly already.
    
    Once the combined mode stuff is redone properly (2.6.21) then the entire
    mess turns into a single pci_request_regions() for all cases and all the
    ugly resource hackery goes away.
    
    I'm sending this now rather than after running full test suites so that
    it can get the maximal testing in a short time. I'll be running tests on
    this after lunch.
    
    Signed-off-by: default avatarAlan Cox <alan@redhat.com>
    Cc: Jeff Garzik <jgarzik@pobox.com>
    Acked-by: default avatarAlessandro Suardi <alessandro.suardi@gmail.com>
    Acked-by: default avatarTheodore Tso <tytso@mit.edu>
    Signed-off-by: default avatarLinus Torvalds <torvalds@osdl.org>
    dc3c3377