Skip to content
  • Michal Hocko's avatar
    memcg swap: use mem_cgroup_uncharge_swap fix · dac23b0d
    Michal Hocko authored
    
    
    Although mem_cgroup_uncharge_swap has an empty placeholder for
    !CONFIG_CGROUP_MEM_RES_CTLR_SWAP the definition is placed in the
    CONFIG_SWAP ifdef block so we are missing the same definition for
    !CONFIG_SWAP which implies !CONFIG_CGROUP_MEM_RES_CTLR_SWAP.
    
    This has not been an issue before, because mem_cgroup_uncharge_swap was
    not called from !CONFIG_SWAP context.  But Hugh Dickins has a cleanup
    patch to call __mem_cgroup_commit_charge_swapin which is defined also
    for !CONFIG_SWAP.
    
    Let's move both the empty definition and declaration outside of the
    CONFIG_SWAP block to avoid the following compilation error:
    
      mm/memcontrol.c: In function '__mem_cgroup_commit_charge_swapin':
      mm/memcontrol.c:2837: error: implicit declaration of function 'mem_cgroup_uncharge_swap'
    
    if CONFIG_SWAP is disabled.
    
    Reported-by: default avatarDavid Rientjes <rientjes@google.com>
    Signed-off-by: default avatarMichal Hocko <mhocko@suse.cz>
    Cc: Hugh Dickins <hughd@google.com>
    Cc: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
    Cc: Daisuke Nishimura <nishimura@mxp.nes.nec.co.jp>
    Cc: Johannes Weiner <hannes@cmpxchg.org>
    Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
    Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
    dac23b0d