• Paul Gortmaker's avatar
    mm/mm_init.c: make creation of the mm_kobj happen earlier than device_initcall · da29bd36
    Paul Gortmaker authored
    The use of __initcall is to be eventually replaced by choosing one from
    the prioritized groupings laid out in init.h header:
    	pure_initcall               0
    	core_initcall               1
    	postcore_initcall           2
    	arch_initcall               3
    	subsys_initcall             4
    	fs_initcall                 5
    	device_initcall             6
    	late_initcall               7
    In the interim, all __initcall are mapped onto device_initcall, which as
    can be seen above, comes quite late in the ordering.
    Currently the mm_kobj is created with __initcall in mm_sysfs_init().
    This means that any other initcalls that want to reference the mm_kobj
    have to be device_initcall (or later), otherwise we will for example,
    trip the BUG_ON(!kobj) in sysfs's internal_create_group().  This
    unfairly restricts those users; for example something that clearly makes
    sense to be an arch_initcall will not be able to choose that.
    However, upon examination, it is only this way for historical reasons
    (i.e.  simply not reprioritized yet).  We see that sysfs is ready quite
    earlier in init/main.c via:
     |_ mnt_init
        |_ sysfs_init
    well ahead of the processing of the prioritized calls listed above.
    So we can recategorize mm_sysfs_init to be a pure_initcall, which in
    turn allows any mm_kobj initcall users a wider range (1 --> 7) of
    initcall priorities to choose from.
    Signed-off-by: default avatarPaul Gortmaker <paul.gortmaker@windriver.com>
    Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
    Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
mm_init.c 5.05 KB