• Vlad Yasevich's avatar
    [SCTP]: Do not interleave non-fragments when in partial delivery · d0cf0d99
    Vlad Yasevich authored
    The way partial delivery is currently implemnted, it is possible to
    intereleave a message (either from another steram, or unordered) that
    is not part of partial delivery process.  The only way to this is for
    a message to not be a fragment and be 'in order' or unorderd for a
    given stream.  This will result in bypassing the reassembly/ordering
    queues where things live duing partial delivery, and the
    message will be delivered to the socket in the middle of partial delivery.
    This is a two-fold problem, in that:
    1.  the app now must check the stream-id and flags which it may not
    be doing.
    2.  this clearing partial delivery state from the association and results
    in ulp hanging.
    This patch is a band-aid over a much bigger problem in that we
    don't do stream interleave.
    Signed-off-by: default avatarVlad Yasevich <vladislav.yasevich@hp.com>
    Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
ulpqueue.c 22.6 KB