Skip to content
  • H. Peter Anvin's avatar
    avoid overflows in kernel/time.c · bdc80787
    H. Peter Anvin authored
    
    
    When the conversion factor between jiffies and milli- or microseconds is
    not a single multiply or divide, as for the case of HZ == 300, we currently
    do a multiply followed by a divide.  The intervening result, however, is
    subject to overflows, especially since the fraction is not simplified (for
    HZ == 300, we multiply by 300 and divide by 1000).
    
    This is exposed to the user when passing a large timeout to poll(), for
    example.
    
    This patch replaces the multiply-divide with a reciprocal multiplication on
    32-bit platforms.  When the input is an unsigned long, there is no portable
    way to do this on 64-bit platforms there is no portable way to do this
    since it requires a 128-bit intermediate result (which gcc does support on
    64-bit platforms but may generate libgcc calls, e.g.  on 64-bit s390), but
    since the output is a 32-bit integer in the cases affected, just simplify
    the multiply-divide (*3/10 instead of *300/1000).
    
    The reciprocal multiply used can have off-by-one errors in the upper half
    of the valid output range.  This could be avoided at the expense of having
    to deal with a potential 65-bit intermediate result.  Since the intent is
    to avoid overflow problems and most of the other time conversions are only
    semiexact, the off-by-one errors were considered an acceptable tradeoff.
    
    At Ralf Baechle's suggestion, this version uses a Perl script to compute
    the necessary constants.  We already have dependencies on Perl for kernel
    compiles.  This does, however, require the Perl module Math::BigInt, which
    is included in the standard Perl distribution starting with version 5.8.0.
    In order to support older versions of Perl, include a table of canned
    constants in the script itself, and structure the script so that
    Math::BigInt isn't required if pulling values from said table.
    
    Running the script requires that the HZ value is available from the
    Makefile.  Thus, this patch also adds the Kconfig variable CONFIG_HZ to the
    architectures which didn't already have it (alpha, cris, frv, h8300, m32r,
    m68k, m68knommu, sparc, v850, and xtensa.) It does *not* touch the sh or
    sh64 architectures, since Paul Mundt has dealt with those separately in the
    sh tree.
    
    Signed-off-by: default avatarH. Peter Anvin <hpa@zytor.com>
    Cc: Ralf Baechle <ralf@linux-mips.org>,
    Cc: Sam Ravnborg <sam@ravnborg.org>,
    Cc: Paul Mundt <lethal@linux-sh.org>,
    Cc: Richard Henderson <rth@twiddle.net>,
    Cc: Michael Starvik <starvik@axis.com>,
    Cc: David Howells <dhowells@redhat.com>,
    Cc: Yoshinori Sato <ysato@users.sourceforge.jp>,
    Cc: Hirokazu Takata <takata@linux-m32r.org>,
    Cc: Geert Uytterhoeven <geert@linux-m68k.org>,
    Cc: Roman Zippel <zippel@linux-m68k.org>,
    Cc: William L. Irwin <sparclinux@vger.kernel.org>,
    Cc: Chris Zankel <chris@zankel.net>,
    Cc: H. Peter Anvin <hpa@zytor.com>,
    Cc: Jan Engelhardt <jengelh@computergmbh.de>
    Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
    Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
    bdc80787