Skip to content
  • Wu Fengguang's avatar
    tcp: replace hard coded GFP_KERNEL with sk_allocation · aa133076
    Wu Fengguang authored
    
    
    This fixed a lockdep warning which appeared when doing stress
    memory tests over NFS:
    
    	inconsistent {RECLAIM_FS-ON-W} -> {IN-RECLAIM_FS-W} usage.
    
    	page reclaim => nfs_writepage => tcp_sendmsg => lock sk_lock
    
    	mount_root => nfs_root_data => tcp_close => lock sk_lock =>
    			tcp_send_fin => alloc_skb_fclone => page reclaim
    
    David raised a concern that if the allocation fails in tcp_send_fin(), and it's
    GFP_ATOMIC, we are going to yield() (which sleeps) and loop endlessly waiting
    for the allocation to succeed.
    
    But fact is, the original GFP_KERNEL also sleeps. GFP_ATOMIC+yield() looks
    weird, but it is no worse the implicit sleep inside GFP_KERNEL. Both could
    loop endlessly under memory pressure.
    
    CC: Arnaldo Carvalho de Melo <acme@ghostprotocols.net>
    CC: David S. Miller <davem@davemloft.net>
    CC: Herbert Xu <herbert@gondor.apana.org.au>
    Signed-off-by: default avatarWu Fengguang <fengguang.wu@intel.com>
    Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
    aa133076