Skip to content
  • Michael Buesch's avatar
    mac80211: quiet beacon loss messages · a860402d
    Michael Buesch authored
    
    
    On Sunday 05 April 2009 11:29:38 Michael Buesch wrote:
    > On Sunday 05 April 2009 11:23:59 Jaswinder Singh Rajput wrote:
    > > With latest linus tree I am getting, .config file attached:
    > >
    > > [   22.895051] r8169: eth0: link down
    > > [   22.897564] ADDRCONF(NETDEV_UP): eth0: link is not ready
    > > [   22.928047] ADDRCONF(NETDEV_UP): wlan0: link is not ready
    > > [   22.982292] libvirtd used greatest stack depth: 4200 bytes left
    > > [   63.709879] wlan0: authenticate with AP 00:11:95:9e:df:f6
    > > [   63.712096] wlan0: authenticated
    > > [   63.712127] wlan0: associate with AP 00:11:95:9e:df:f6
    > > [   63.726831] wlan0: RX AssocResp from 00:11:95:9e:df:f6 (capab=0x471 status=0 aid=1)
    > > [   63.726855] wlan0: associated
    > > [   63.730093] ADDRCONF(NETDEV_CHANGE): wlan0: link becomes ready
    > > [   74.296087] wlan0: no IPv6 routers present
    > > [   79.349044] wlan0: beacon loss from AP 00:11:95:9e:df:f6 - sending probe request
    > > [  119.358200] wlan0: beacon loss from AP 00:11:95:9e:df:f6 - sending probe request
    > > [  179.354292] wlan0: beacon loss from AP 00:11:95:9e:df:f6 - sending probe request
    > > [  259.366044] wlan0: beacon loss from AP 00:11:95:9e:df:f6 - sending probe request
    > > [  359.348292] wlan0: beacon loss from AP 00:11:95:9e:df:f6 - sending probe request
    > > [  361.953459] packagekitd used greatest stack depth: 4160 bytes left
    > > [  478.824258] wlan0: beacon loss from AP 00:11:95:9e:df:f6 - sending probe request
    > > [  598.813343] wlan0: beacon loss from AP 00:11:95:9e:df:f6 - sending probe request
    > > [  718.817292] wlan0: beacon loss from AP 00:11:95:9e:df:f6 - sending probe request
    > > [  838.824567] wlan0: beacon loss from AP 00:11:95:9e:df:f6 - sending probe request
    > > [  958.815402] wlan0: beacon loss from AP 00:11:95:9e:df:f6 - sending probe request
    > > [ 1078.848434] wlan0: beacon loss from AP 00:11:95:9e:df:f6 - sending probe request
    > > [ 1198.822913] wlan0: beacon loss from AP 00:11:95:9e:df:f6 - sending probe request
    > > [ 1318.824931] wlan0: beacon loss from AP 00:11:95:9e:df:f6 - sending probe request
    > > [ 1438.814157] wlan0: beacon loss from AP 00:11:95:9e:df:f6 - sending probe request
    > > [ 1558.827336] wlan0: beacon loss from AP 00:11:95:9e:df:f6 - sending probe request
    > > [ 1678.823011] wlan0: beacon loss from AP 00:11:95:9e:df:f6 - sending probe request
    > > [ 1798.830589] wlan0: beacon loss from AP 00:11:95:9e:df:f6 - sending probe request
    > > [ 1918.828044] wlan0: beacon loss from AP 00:11:95:9e:df:f6 - sending probe request
    > > [ 2038.827224] wlan0: beacon loss from AP 00:11:95:9e:df:f6 - sending probe request
    > > [ 2116.517152] wlan0: beacon loss from AP 00:11:95:9e:df:f6 - sending probe request
    > > [ 2158.840243] wlan0: beacon loss from AP 00:11:95:9e:df:f6 - sending probe request
    > > [ 2278.827427] wlan0: beacon loss from AP 00:11:95:9e:df:f6 - sending probe request
    >
    >
    > I think this message should only show if CONFIG_MAC80211_VERBOSE_DEBUG is set.
    > It's kind of expected that we lose a beacon once in a while, so we shouldn't print
    > verbose messages to the kernel log (even if they are KERN_DEBUG).
    >
    > And besides that, I think one can easily remotely trigger this message and flood the logs.
    > So it should probably _also_ be ratelimited.
    
    Something like this:
    
    Signed-off-by: default avatarMichael Buesch <mb@bu3sch.de>
    a860402d