Skip to content
  • Jan Beulich's avatar
    3c59x: fix regression from patch "Add ethtool WOL support" · 3fd6c88e
    Jan Beulich authored
    This patch (commit 690a1f20
    
    ) added a
    new call site for acpi_set_WOL() without checking that the function is
    actually suitable to be called via
    
     vortex_set_wol+0xcd/0xe0 [3c59x]
     dev_ethtool+0xa5a/0xb70
     dev_ioctl+0x2e0/0x4b0
     T.961+0x49/0x50
     sock_ioctl+0x47/0x290
     do_vfs_ioctl+0x7f/0x340
     sys_ioctl+0x80/0xa0
     system_call_fastpath+0x16/0x1b
    
    i.e. outside of code paths run when the device is not yet enabled or
    already disabled. In particular, putting the device into D3hot is a
    pretty bad idea when it was already brought up.
    
    Furthermore, all prior callers of the function made sure they're
    actually dealing with a PCI device, while the newly added one didn't.
    
    In the same spirit, the .get_wol handler shouldn't indicate support
    for WOL for non-PCI devices.
    
    Signed-off-by: default avatarJan Beulich <jbeulich@novell.com>
    Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
    3fd6c88e