• Tobias Klauser's avatar
    net: xgene: Check negative return value of xgene_enet_get_ring_size() · 9b9ba821
    Tobias Klauser authored
    xgene_enet_get_ring_size() returns a negative value in case of an error,
    but its only caller in xgene_enet_create_desc_ring() currently uses the
    return value directly as u32. Instead, check for a negative value first and
    error out in case. Also move the call to xgene_enet_get_ring_size() before
    devm_kzalloc() so we don't need to free anything in the error path.
    This fixes the following issue reported by the Coverity Scanner:
    ** CID 1231336:  Improper use of negative value  (NEGATIVE_RETURNS)
    /drivers/net/ethernet/apm/xgene/xgene_enet_main.c: 596 in xgene_enet_create_desc_ring()
    Signed-off-by: default avatarTobias Klauser <tklauser@distanz.ch>
    Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>