• Nicolas Pitre's avatar
    ARM: 7186/1: fix Kconfig issue with PHYS_OFFSET and !MMU · 974c0724
    Nicolas Pitre authored
    Commit 1b9f95f8 (ARM: prepare for removal of a bunch of <mach/memory.h>
    files) introduced CONFIG_PHYS_OFFSET but the Kconfig hex prompt did not
    provide a default value.
    This has the undesired side effect of breaking a reportedly used
    trick for updating defconfigs on the fly for routine buildtesting
    across all arch and all platforms, i.e.
    	cp /path/to/somedefconfig .config ; yes "" | make oldconfig
    because the config system will endlessly loop until a valid address is
    However we can't just pick a random default value since it is likely to
    be wrong for the majority of the boards as the right answer for this
    option is quite varied.  So the fact that the config system insists on
    having a proper value be entered is actually a good thing.
    It turns out that only at91x40_defconfig has this problem because it has
    CONFIG_MMU=n. However, in the !MMU case, there is already a CONFIG_DRAM_BASE
    value that can be used here.  So let's use that as a default in that case
    and suppress the redundant CONFIG_PHYS_OFFSET prompt.
    Eventually the DRAM_BASE config option could simply be replaced by
    PHYS_OFFSET directly, but that's a larger change better suited for later.
    Reported-by: default avatarPaul Gortmaker <paul.gortmaker@windriver.com>
    Signed-off-by: default avatarNicolas Pitre <nico@linaro.org>
    Acked-by: default avatarUwe Kleine-König <u.kleine-koenig@pengutronix.de>
    Signed-off-by: default avatarRussell King <rmk+kernel@arm.linux.org.uk>
Kconfig 64.1 KB