• Jesper Juhl's avatar
    [IPV4]: [3/4] signed vs unsigned cleanup in net/ipv4/raw.c · 93765d8a
    Jesper Juhl authored
    This patch changes the type of the local variable 'i' in 
    raw_probe_proto_opt() from 'int' to 'unsigned int'. The only use of 'i' in 
    this function is as a counter in a for() loop and subsequent index into 
    the msg->msg_iov[] array.
    Since 'i' is compared in a loop to the unsigned variable msg->msg_iovlen 
    gcc -W generates this warning : 
    net/ipv4/raw.c:340: warning: comparison between signed and unsigned
    Changing 'i' to unsigned silences this warning and is safe since the array 
    index can never be negative anyway, so unsigned int is the logical type to 
    use for 'i' and also enables a larger msg_iov[] array (but I don't know if 
    that will ever matter).
    Signed-off-by: default avatarJesper Juhl <juhl-lkml@dif.dk>
    Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
raw.c 19.8 KB