Skip to content
  • Daniel Vetter's avatar
    drm/i915: fix up ilk rc6 disabling confusion · 930ebb46
    Daniel Vetter authored
    While creating the new enable/disable_gt_powersave functions in
    
    commit 8090c6b9
    
    
    Author: Daniel Vetter <daniel.vetter@ffwll.ch>
    Date:   Sun Jun 24 16:42:32 2012 +0200
    
        drm/i915: wrap up gt powersave enabling functions
    
    I've botched up the handling of ironlake_disable_rc6. Fix this up by
    calling it at the right place. Note though that ironlake_disable_rc6
    does a bit more than just disabling rc6 - it also tears down all the
    allocated context objects.
    
    Hence we need to move intel_teardown_rc6 out and directly call it from
    intel_modeset_cleanup.
    
    Also properly mark ironlake_enable_rc6 as static and kill the un-used
    declaration in i915_drv.h.
    
    Note: In review a question popped out why disable_rc6 also tears down
    the backing object and why we should move that out - it's simply for
    consistency with gen6+ rps code, which does it that way.
    
    Cc: Ben Widawsky <ben@bwidawsk.net>
    Reviewed-by: default avatarEugeni Dodonov <eugeni.dodonov@intel.com>
    Reviewed-by: default avatarBen Widawsky <ben@bwidawsk.net>
    Signed-Off-by: default avatarDaniel Vetter <daniel.vetter@ffwll.ch>
    930ebb46