Skip to content
  • Mark Rutland's avatar
    ARM: perf: remove unnecessary checks for idx < 0 · 8f3b90b5
    Mark Rutland authored
    
    
    We currently check for hwx->idx < 0 in armpmu_read and armpmu_del
    unnecessarily. The only case where hwc->idx < 0 is when armpmu_add
    fails, in which case the event's state is set to
    PERF_EVENT_STATE_INACTIVE.
    
    The perf core will not attempt to read from an event in
    PERF_EVENT_STATE_INACTIVE, and so the check in armpmu_read is
    unnecessary. Similarly, if perf core cannot add an event it will not
    attempt to delete it, so the WARN_ON in armpmu_del is unnecessary.
    
    This patch removes these two redundant checks.
    
    Signed-off-by: default avatarMark Rutland <mark.rutland@arm.com>
    Signed-off-by: default avatarWill Deacon <will.deacon@arm.com>
    8f3b90b5