Skip to content
  • Eric W. Biederman's avatar
    sysctl: Error on bad sysctl tables · fc6cd25b
    Eric W. Biederman authored
    
    
    After going through the kernels sysctl tables several times it has become
    clear that code review and testing is just not effective in prevent
    problematic sysctl tables from being used in the stable kernel.  I certainly
    can't seem to fix the problems as fast as they are introduced.
    
    Therefore this patch adds sysctl_check_table which is called when a sysctl
    table is registered and checks to see if we have a problematic sysctl table.
    
    The biggest part of the code is the table of valid binary sysctl entries, but
    since we have frozen our set of binary sysctls this table should not need to
    change, and it makes it much easier to detect when someone unintentionally
    adds a new binary sysctl value.
    
    As best as I can determine all of the several hundred errors spewed on boot up
    now are legitimate.
    
    [bunk@kernel.org: kernel/sysctl_check.c must #include <linux/string.h>]
    Signed-off-by: default avatarEric W. Biederman <ebiederm@xmission.com>
    Cc: Alexey Dobriyan <adobriyan@sw.ru>
    Signed-off-by: default avatarAdrian Bunk <bunk@kernel.org>
    Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
    Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
    fc6cd25b