Skip to content
  • Robert Peterson's avatar
    [GFS2] kernel changes to support new gfs2_grow command · 7ae8fa84
    Robert Peterson authored
    
    
    This is another revision of my gfs2 kernel patch that allows
    gfs2_grow to function properly.
    
    Steve Whitehouse expressed some concerns about the previous
    patch and I restructured it based on his comments.
    The previous patch was doing the statfs_change at file close time,
    under its own transaction.  The current patch does the statfs_change
    inside the gfs2_commit_write function, which keeps it under the
    umbrella of the inode transaction.
    
    I can't call ri_update to re-read the rindex file during the
    transaction because the transaction may have outstanding unwritten
    buffers attached to the rgrps that would be otherwise blown away.
    So instead, I created a new function, gfs2_ri_total, that will
    re-read the rindex file just to total the file system space
    for the sake of the statfs_change.  The ri_update will happen
    later, when gfs2 realizes the version number has changed, as it
    happened before my patch.
    
    Since the statfs_change is happening at write_commit time and there
    may be multiple writes to the rindex file for one grow operation.
    So one consequence of this restructuring is that instead of getting
    one kernel message to indicate the change, you may see several.
    For example, before when you did a gfs2_grow, you'd get a single
    message like:
    
    GFS2: File system extended by 247876 blocks (968MB)
    
    Now you get something like:
    
    GFS2: File system extended by 207896 blocks (812MB)
    GFS2: File system extended by 39980 blocks (156MB)
    
    This version has also been successfully run against the hours-long
    "gfs2_fsck_hellfire" test that does several gfs2_grow and gfs2_fsck
    while interjecting file system damage.  It does this repeatedly
    under a variety Resource Group conditions.
    
    Signed-off-By: default avatarBob Peterson <rpeterso@redhat.com>
    Signed-off-by: default avatarSteven Whitehouse <swhiteho@redhat.com>
    7ae8fa84