Skip to content
  • Julia Lawall's avatar
    MIPS: TXx9: Fix error handling. · 70ebadc8
    Julia Lawall authored
    Error handling code following a kzalloc should free the allocated data.
    Error handling code following an ioremap should iounmap the allocated data.
    
    The semantic match that finds the first problem is as follows:
    (http://www.emn.fr/x-info/coccinelle/
    
    )
    
    // <smpl>
    @r exists@
    local idexpression x;
    statement S;
    expression E;
    identifier f,f1,l;
    position p1,p2;
    expression *ptr != NULL;
    @@
    
    x@p1 = \(kmalloc\|kzalloc\|kcalloc\)(...);
    ...
    if (x == NULL) S
    <... when != x
         when != if (...) { <+...x...+> }
    (
    x->f1 = E
    |
     (x->f1 == NULL || ...)
    |
     f(...,x->f1,...)
    )
    ...>
    (
     return \(0\|<+...x...+>\|ptr\);
    |
     return@p2 ...;
    )
    
    @script:python@
    p1 << r.p1;
    p2 << r.p2;
    @@
    
    print "* file: %s kmalloc %s return %s" % (p1[0].file,p1[0].line,p2[0].line)
    // </smpl>
    
    Signed-off-by: default avatarJulia Lawall <julia@diku.dk>
    Signed-off-by: default avatarRalf Baechle <ralf@linux-mips.org>
    70ebadc8