Skip to content
  • Luis R. Rodriguez's avatar
    kernel/module.c: avoid ifdefs for sig_enforce declaration · 6727bb9c
    Luis R. Rodriguez authored
    
    
    There's no need to require an ifdef over the declaration
    of sig_enforce as IS_ENABLED() can be used. While at it,
    there's no harm in exposing this kernel parameter outside of
    CONFIG_MODULE_SIG as it'd be a no-op on non module sig
    kernels.
    
    Now, technically we should in theory be able to remove
    the #ifdef'ery over the declaration of the module parameter
    as we are also trusting the bool_enable_only code for
    CONFIG_MODULE_SIG kernels but for now remain paranoid
    and keep it.
    
    With time if no one can put a bullet through bool_enable_only
    and if there are no technical requirements over not exposing
    CONFIG_MODULE_SIG_FORCE with the measures in place by
    bool_enable_only we could remove this last ifdef.
    
    Cc: Rusty Russell <rusty@rustcorp.com.au>
    Cc: Andrew Morton <akpm@linux-foundation.org>
    Cc: Kees Cook <keescook@chromium.org>
    Cc: Tejun Heo <tj@kernel.org>
    Cc: Ingo Molnar <mingo@kernel.org>
    Cc: linux-kernel@vger.kernel.org
    Cc: cocci@systeme.lip6.fr
    Signed-off-by: default avatarLuis R. Rodriguez <mcgrof@suse.com>
    Signed-off-by: default avatarRusty Russell <rusty@rustcorp.com.au>
    6727bb9c