Skip to content
  • Ingo Molnar's avatar
    lockdep: annotate reclaim context (__GFP_NOFS), fix · 6700ec65
    Ingo Molnar authored
    
    
    Impact: fix build warning
    
    Fix:
    
      mm/vmscan.c: In function ‘kswapd’:
      mm/vmscan.c:1969: warning: ISO C90 forbids mixed declarations and code
    
    node_to_cpumask_ptr(cpumask, pgdat->node_id), has a side-effect: it
    defines the 'cpumask' local variable as well, so it has to go into
    the variable definition section.
    
    Sidenote: it might make sense to make this purpose of these macros
    more apparent, by naming them the standard way, such as:
    
      DEFINE_node_to_cpumask_ptr(cpumask, pgdat->node_id);
    
    (But that is outside the scope of this patch.)
    
    Cc: Rusty Russell <rusty@rustcorp.com.au>
    Cc: Mike Travis <travis@sgi.com>
    Cc: Andrew Morton <akpm@linux-foundation.org>
    Cc: Nick Piggin <npiggin@suse.de>
    Signed-off-by: default avatarIngo Molnar <mingo@elte.hu>
    6700ec65