• Eric Dumazet's avatar
    ipv4: tcp: fix TOS value in ACK messages sent from TIME_WAIT · 66b13d99
    Eric Dumazet authored
    There is a long standing bug in linux tcp stack, about ACK messages sent
    on behalf of TIME_WAIT sockets.
    In the IP header of the ACK message, we choose to reflect TOS field of
    incoming message, and this might break some setups.
    Example of things that were broken :
      - Routing using TOS as a selector
      - Firewalls
      - Trafic classification / shaping
    We now remember in timewait structure the inet tos field and use it in
    ACK generation, and route lookup.
    Notes :
     - We still reflect incoming TOS in RST messages.
     - We could extend MuraliRaja Muniraju patch to report TOS value in
    netlink messages for TIME_WAIT sockets.
     - A patch is needed for IPv6
    Signed-off-by: default avatarEric Dumazet <eric.dumazet@gmail.com>
    Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
inet_timewait_sock.h 6.89 KB