Skip to content
  • Gerrit Renker's avatar
    [DCCP] ccid3: Consolidate handling of t_RTO · 5d0dbc4a
    Gerrit Renker authored
    
    
    This patch
     * removes setting t_RTO in ccid3_hc_tx_init (per [RFC 3448, 4.2], t_RTO is
       undefined until feedback has been received);
    
     * makes some trivial changes (updates of comments);
    
     * performs a small optimisation by exploiting that the feedback timeout
       uses the value of t_ipi. The way it is done is safe, because the timeouts
       appear after the changes to t_ipi, ensuring that up-to-date values are used;
    
     * in ccid3_hc_tx_packet_recv, moves the t_rto statement closer to the calculation
       of the next_tmout. This makes the code clearer to read and is also safe, since
       t_rto is not updated until the next call of ccid3_hc_tx_packet_recv, and is not
       read by the functions called via ccid_wait_for_ccid();
    
     * removes a `max' statement in sk_reset_timer, this is not needed since the timeout
       value is always greater than 1E6 microseconds.
    
     * adds `XXX'es to highlight that currently the nofeedback timer is set
       in a non-standard way
    
    Signed-off-by: default avatarGerrit Renker <gerrit@erg.abdn.ac.uk>
    Acked-by: default avatarIan McDonald <ian.mcdonald@jandi.co.nz>
    Signed-off-by: default avatarArnaldo Carvalho de Melo <acme@mandriva.com>
    5d0dbc4a