Skip to content
  • Cedric Le Goater's avatar
    cgroups: remove node_ prefix_from ns subsystem · 5c02b575
    Cedric Le Goater authored
    
    
    This is a slight change in the namespace cgroup subsystem api.
    
    The change is that previously when cgroup_clone() was called (currently
    only from the unshare path in ns_proxy cgroup, you'd get a new group named
    "node_$pid" whereas now you'll get a group named after just your pid.)
    
    The only users who would notice it are those who are using the ns_proxy
    cgroup subsystem to auto-create cgroups when namespaces are unshared -
    something of an experimental feature, which I think really needs more
    complete container/namespace support in order to be useful.  I suspect the
    only users are Cedric and Serge, or maybe a few others on
    containers@lists.linux-foundation.org.  And in fact it would only be
    noticed by the users who make the assumption about how the name is
    generated, rather than getting it from the /proc/<pid>/cgroups file for
    the process in question.
    
    Whether the change is actually needed or not I'm fairly agnostic on, but I
    guess it is more elegant to just use the pid as the new group name rather
    than adding a fairly arbitrary "node_" prefix on the front.
    
    [menage@google.com: provided changelog]
    Signed-off-by: default avatarCedric Le Goater <clg@fr.ibm.com>
    Cc: "Paul Menage" <menage@google.com>
    Cc: "Serge E. Hallyn" <serue@us.ibm.com>
    Cc: <stable@kernel.org>
    Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
    Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
    5c02b575