• andrew.vasquez@qlogic.com's avatar
    [SCSI] qla2xxx: Correct excessive delay during LOAD-RISC-RAM mailbox command. · 59989831
    andrew.vasquez@qlogic.com authored
    Problem report (against 2.4.x driver) from Jeff Layton
    An OEM noticed that the U6 qla2200 driver would hang for
    around 2 minutes at boot time and then proceed normally. I
    found that the delay was occurring when loading the new
    firmware into the card, and was due to a
    schedule_timeout(10) added to the bottom of the polling
    Some testing showed that the load ram operation on the card
    was very quick (on the order of a couple of jiffies), but
    the sleep in the polling loop was making each operation take
    around 25-30.
    The attached patch corrects this by making it skip sleeping
    during the load ram operation, since I believe we only do
    that when the module is plugged in. It also skips sleeping
    if the mbox_int flag got set during the current loop.
    This corrected the hang on my test setup, and OEM also
    confirmed that it corrected the problem for them.
    Signed-off-by: default avatarAndrew Vasquez <andrew.vasquez@qlogic.com>
    Signed-off-by: default avatarJames Bottomley <James.Bottomley@SteelEye.com>
qla_mbx.c 58.8 KB