Skip to content
  • Jiri Olsa's avatar
    perf tools: Fix -x/--exclude-other option for report command · 0276c22a
    Jiri Olsa authored
    
    
    Currently we have symbol_conf.exclude_other being set as true every time
    so the -x/--exclude-other has nothing to do.
    
    Also we have no way to see the data with symbol_conf.exclude_other being
    false which is useful sometimes.
    
    Fixing it by making symbol_conf.exclude_other false by default.
    
    1) Example without -x option:
    
      $ perf report -i perf.data.delete -p perf_session__delete -s parent
    
      +  99.91%  [other]
      +   0.08%  perf_session__delete
      +   0.00%  perf_session__delete_dead_threads
      +   0.00%  perf_session__delete_threads
    
    2) Example with -x option:
    
      $ ./perf report -i perf.data.delete -p perf_session__delete -s parent -x
    
      +  96.22%  perf_session__delete
      +   1.89%  perf_session__delete_dead_threads
      +   1.89%  perf_session__delete_threads
    
    In Example 1) we get the sorted out data together with the rest
    "[other]". This could help us estimate how much time we spent in the
    sorted data.
    
    In Example 2) the total is just the sorted data.
    
    Signed-off-by: default avatarJiri Olsa <jolsa@redhat.com>
    Cc: Andi Kleen <ak@linux.intel.com>
    Cc: Corey Ashford <cjashfor@linux.vnet.ibm.com>
    Cc: David Ahern <dsahern@gmail.com>
    Cc: Frederic Weisbecker <fweisbec@gmail.com>
    Cc: Ingo Molnar <mingo@elte.hu>
    Cc: Namhyung Kim <namhyung@kernel.org>
    Cc: Paul Mackerras <paulus@samba.org>
    Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
    Link: http://lkml.kernel.org/n/tip-sg8fvu0fyqohf9ur9l38lhkw@git.kernel.org
    
    
    Signed-off-by: default avatarArnaldo Carvalho de Melo <acme@redhat.com>
    0276c22a