Skip to content
  • Arnd Bergmann's avatar
    dsa: b53: fix big-endian register access · 55e7f6ab
    Arnd Bergmann authored
    
    
    The b53 dsa register access confusingly uses __raw register accessors
    when both the CPU and the device are big-endian, but it uses little-
    endian accessors when the same device is used from a little-endian
    CPU, which makes no sense.
    
    This uses normal accessors in device-endianess all the time, which
    will work in all four combinations of register and CPU endianess,
    and it will have the same barrier semantics in all cases.
    
    This also seems to take care of a (false positive) warning I'm getting:
    
    drivers/net/dsa/b53/b53_mmap.c: In function 'b53_mmap_read64':
    drivers/net/dsa/b53/b53_mmap.c:109:10: error: 'hi' may be used uninitialized in this function [-Werror=maybe-uninitialized]
      *val = ((u64)hi << 32) | lo;
    
    I originally planned to submit another patch for that warning
    and did this one as a preparation cleanup, but it does seem to be
    sufficient by itself.
    
    Signed-off-by: default avatarArnd Bergmann <arnd@arndb.de>
    Acked-by: default avatarFlorian Fainelli <f.fainelli@gmail.com>
    Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
    55e7f6ab