Skip to content
  • Bob Peterson's avatar
    [GFS2] GFS2: chmod hung - fix race in thread creation · 55c0c4ac
    Bob Peterson authored
    
    
    The problem boiled down to a race between the gdlm_init_threads()
    function initializing thread1 and its setting of blist = 1.
    Essentially, "if (current == ls->thread1)" was checked by the thread
    before the thread creator set ls->thread1.
    
    Since thread1 is the only thread who is allowed to work on the
    blocking queue, and since neither thread thought it was thread1, no one
    was working on the queue.  So everything just sat.
    
    This patch reuses the ls->async_lock spin_lock to fix the race,
    and it fixes the problem.  I've done more than 2000 iterations of the
    loop that was recreating the failure and it seems to work.
    
    Signed-off-by: default avatarBob Peterson <rpeterso@redhat.com>
    Signed-off-by: default avatarSteven Whitehouse <swhiteho@redhat.com>
    
    --
    55c0c4ac